Skip to content

Commit

Permalink
Remove some commented ideas that aren't quick wins
Browse files Browse the repository at this point in the history
  • Loading branch information
brookslogan committed Mar 4, 2025
1 parent e99b7df commit e8ffe49
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions R/epix_epi_slide_opt.R
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# TODO just make this an epi_slide_opt impl?
epix_epi_slide_opt_one_epikey <- function(updates, in_colnames, f_dots_baked, f_from_package, before, after, time_type, out_colnames) {
unit_step <- epiprocess:::unit_time_delta(time_type)
prev_inp_snapshot <- NULL
Expand Down Expand Up @@ -68,16 +67,18 @@ epix_epi_slide_opt_one_epikey <- function(updates, in_colnames, f_dots_baked, f_
!is.na(slide_inp_backrefs)
}
out_update <- slide[rows_should_keep, ]
out_diff <- tbl_diff2(prev_out_snapshot, out_update, "time_value", "update") # TODO avoid redundant diff2 work? though depends on compactify parms...
out_diff <- tbl_diff2(prev_out_snapshot, out_update, "time_value", "update")
out_snapshot <- tbl_patch(prev_out_snapshot, out_diff, "time_value")
prev_inp_snapshot <<- inp_snapshot
prev_out_snapshot <<- out_snapshot # TODO avoid need to patch twice?
prev_out_snapshot <<- out_snapshot
out_diff$version <- version
out_diff
})
result
}

# TODO just make this an epi_slide_opt impl?

#' @export
epix_epi_slide_opt <-
function(.x, .col_names, .f, ...,
Expand Down

0 comments on commit e8ffe49

Please sign in to comment.