-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete incorrect comment regarding as_tibble
#417
Comments
If we wanted to be more careful here, we could try to detect column-aliasing & copy in that case. |
Another probably-inaccurate comment:
|
It might actually be okay to alias in these cases if we never mutate archive DT columns without copying first (and if the user doesn't mutate the |
* remove comment #417 * bump version to 0.7.6 and add NEWS line
This is out of date, these comments were removed/modified a while ago. |
We say that
as_tibble
de-aliasesdata.table
columns here, but it doesn't. We should still probably be good since[.data.table
with ani
arg (but notunique.data.table
, probably a bug) seems to consistently copy. It's just the comment that's wrong.The text was updated successfully, but these errors were encountered: