Skip to content

Are reexports necessary? #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
dajmcdon opened this issue May 24, 2022 · 0 comments
Open

Are reexports necessary? #82

dajmcdon opened this issue May 24, 2022 · 0 comments
Labels
cleanup improvements to developing&building experience&quality, not directly to built pkg&docs P3 very low priority

Comments

@dajmcdon
Copy link
Contributor

I'm not sure whether these reexports are necessary. This guide section 13.6.2 seems to suggest the importing would be sufficient. If there are check complaints, maybe these are from examples not library-ing in magrittr/dplyr/tidyr and/or using scope operators for functions?

(But the reexports don't seem to do any harm... printing the functions still seems to identify dplyr as the source/namespace. I guess there is the side effect of clobbering stats::filter, but I'd guess people are used to that / want that all the time now.)

Originally posted by @brookslogan in #77 (comment)
@dajmcdon dajmcdon mentioned this issue May 24, 2022
Merged
@brookslogan brookslogan added P3 very low priority cleanup improvements to developing&building experience&quality, not directly to built pkg&docs labels May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup improvements to developing&building experience&quality, not directly to built pkg&docs P3 very low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dajmcdon @brookslogan