Move to CI, include data, clean up dependencies, add examples #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'main' of https://github.com/dajmcdon/epiprocess into cy-add-roxygen-example # Conflicts: # .Rbuildignore
* Generics used from other packages must be reexported * Some missing args now documented * Unpleasantness with S3 methods (see below) Previously, all S3 methods for `epi_df` had `x` as the first argument. But this doesn't actually pass checks. Any method must match the generic signature. So this means replacing `x` with (variously) `object`/`.data`/`data`. This is a bit annoying to document all together. Adding an issue to split the methods up in the docs.
Merge branch 'main' of https://github.com/dajmcdon/epiprocess # Conflicts: # .github/workflows/R-CMD-check.yaml # DESCRIPTION
… for the error. Creating an issue.
Merge branch 'main' of https://github.com/dajmcdon/epiprocess into cy-add-roxygen-example # Conflicts: # .Rbuildignore # DESCRIPTION
Replaced all instances of gginnards.
dajmcdon
commented
May 17, 2022
brookslogan
requested changes
May 18, 2022
| @@ -1,5 +1,10 @@ | |||
| # epiprocess | |||
|
|
|||
| <!-- badges: start --> | |||
| [](https://github.com/dajmcdon/epiprocess/actions) | |||
There was a problem hiding this comment.
I assume the URL here will need to be updated?
There was a problem hiding this comment.
Yeah. Thanks for flagging.
This was referenced May 18, 2022
dajmcdon
commented
May 18, 2022
…ome changes from epiprocess/cmu-delphi#77
dshemetov
reviewed
May 23, 2022
There was a problem hiding this comment.
I realize that I've been putting this off because my mental context is totally in the production forecaster right now. I'm going to sign off on this without review, since Logan has already done a thorough review and I don't want to block this further by building a mental context right now.
This was referenced May 24, 2022
This was referenced May 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just setting this up as a draft for the moment. May need to break into smaller incremental PRs.
@examplesthroughout package (maybe query-less versions of vignette code) #69 . Likely needs a some more though.