update workflow, no more special color handling #566
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dshemetov
reviewed
Nov 12, 2024
.github/workflows/pkgdown.yaml
Outdated
| pkgdown::clean_site(pkg) | ||
| pkgdown::build_site(pkg, preview = FALSE, install = FALSE, new_process = FALSE) | ||
| pkgdown:::build_github_pages(pkg) | ||
| run: pkgdown::build_site_github_pages(new_process = FALSE, install = FALSE) |
There was a problem hiding this comment.
So all the previous code was there to trigger dev docs for the dev branch, rather than basing it on x.y.z.9000 version numbers. I honestly would prefer to move to the latter, default model, but we'll need to adjust our workflows a bit. @dsweber2
There was a problem hiding this comment.
I'll bring this back. I don't think there's a way to change with the dev branch unfortunately. But hopefully we don't need the color handling any more.
|
I let this sit too long and am going to just release dev -> main so we should get the updates from that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please:
PR).
brookslogan, nmdefries.
DESCRIPTION. Always incrementthe patch version number (the third number), unless you are making a
release PR from dev to main, in which case increment the minor version
number (the second number).
(backwards-incompatible changes to the documented interface) are noted.
Collect the changes under the next release number (e.g. if you are on
1.7.2, then write your changes under the 1.8 heading).
process.
Change explanations for reviewer
Magic GitHub syntax to mark associated Issue(s) as resolved when this is merged into the default branch