Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X-Range should persist across selection #623

Closed
tildechris opened this issue Nov 11, 2020 · 3 comments
Closed

X-Range should persist across selection #623

tildechris opened this issue Nov 11, 2020 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@tildechris
Copy link
Contributor

Re: #619

When using the large time series chart, one can use the date range widget to change the range of the plot:

image

Currently if you add another area to the selection, this date range gets reset, causing the user to have to navigate back to the area they found interesting.

We should persist the current date range across geo selections to improve this behavior.

@tildechris tildechris added the enhancement New feature or request label Nov 11, 2020
@dlaliberte
Copy link
Contributor

Probably should also preserve the date range when changing indicators as well.

But once we are preserving the date range everywhere we should, then we may need an easy way to reset to the full date range.

I'd also like to make the date range editable, by dragging one end or the other, rather than dragging the entire date range, or restarting with a new date range if you click outside of it. But that is another issue (that will be fun to work on).

@dlaliberte
Copy link
Contributor

Ignore that erroneous mention relative to Dlaliberte/details2 #640
No idea why GitHub offered to do a pull request for what I had already created a pull request for, and then it turned around and said "there is already a pull request for that".

@dlaliberte
Copy link
Contributor

Closing the Detail View and opening again will restore the default date range to the small multiple time span. That seems like a reasonable compromise for now. We could persist the date range selection longer, but would need some way to reset it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants