Preserve modified date range while DetailView is displayed.

[dlaliberte]

closes #623

Prerequisites:

• Unless it is a hotfix it should be merged against the dev branch
• Branch is up-to-date with the branch to be merged with, i.e. dev
• Build is successful
• Code is cleaned up and formatted

Summary

Preserve the modified date range in the DetailView between changes of sensor or regions. Also entering and exiting compare mode leave the date range as it is. Only closing the DetailView restores the default, next time it is opened.

[netlify]

Preview link ready!

Built with commit ce86141

https://deploy-preview-641--cmu-delphi-covidcast.netlify.app

[netlify]

Preview link ready!

Built with commit 8df489b

https://deploy-preview-641--cmu-delphi-covidcast.netlify.app

[dlaliberte]

It actually fails to preserve the date range the first time after opening the DetailView. And if you select a sensor with no data, it loses the date range entirely.

[dlaliberte]

Fixed the "no data" situation. The failure to preserve the date on the first time doesn't happen if I am watching with the debugger, so there is a timing issue or something that I am not understanding.

[dlaliberte]

Redefined the dateRange variable to use writable, but it still fails (most of the time) the on the first change, but works thereafter. I'm stumped.

[sgratzl]

Redefined the dateRange variable to use writable, but it still fails (most of the time) the on the first change, but works thereafter. I'm stumped.

how can I reproduce that? can you make a screenshot showing the behavior?

[dlaliberte]

how can I reproduce that? can you make a screenshot showing the behavior?

I'm not sure if I can do a screen recording. Need a tool allowed by Google that works with macbook and/or chrome.

But reproducing this is straightforward. On a fresh page (I click on "COVIDcast" link in header),

• starting with Map Overview,
• click on magnifier icon for COVID-Related Doctor Visits,
• drag the date range slider back a couple months,
• click the magnifier for COVID-like Symptoms
• Notice that the date range slider is reset to the small multiple default.
• Try it again (without restarting), and notice it works correctly thereafter.

Actually, the latest version preserves the change after closing the detail view as well, or going to any other view. That's because it is storing it in detailViewTimeSpan, so it never gets reset to the default after that. It only fails the very first time.

[dlaliberte]

Actually, the latest version preserves the change after closing the detail view as well, or going to any other view. That's because it is storing it in detailViewTimeSpan, so it never gets reset to the default after that. It only fails the very first time.

After merging in the latest from origin/dev, now it does work the first time as well. So something has changed maybe about the timing of page loading or whatever, so I wonder if this will be reliable.

Also, the persistence of the date range change could be a useful feature, but now we have the opposite problem, that there is no way to reset to the default, other than refreshing the page. I'll remove it from the store, and see if that works correctly now.

[sgratzl]

looks good beside the one comment regarding the store