-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand all line plots for slow-moving times #1214
Conversation
✅ Preview link ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
This may or may not belong here, but: we should find a way to convey when a gridline indicates a week boundary and when it indicates a month boundary (e.g. a tiny 'M' or 'W' at the top or bottom of the grid line?). Alternatively, or in addition, we can add some text to the beehive to the effect that e.g. "each hive depicts 3 months" of the signal.
I can probably change the "Beehive Grid" toggle label to "3-month Beehive Grid", but adding new text elements isn't something sam made configurable. I can look into it though. How badly do you want it? |
Maybe 1-2 hours worth of badly? |
Okay, I can do the extra labels but the layout options will be limited. Above the color legend: https://jam.dev/c/24b6933b-807b-427e-a732-e4311dd6409b Bottom left: https://jam.dev/c/245f35e3-4a2b-4e84-b49b-17511694cdd3 Bottom right: https://jam.dev/c/eb96cc4a-a80d-475e-88af-68a951cbb2ad |
I found the 0-anchor mode. With the 3-month timespan, it makes no noticeable difference, since nothing stays sufficiently high for more than three months that you can tell whether the lowest value is at the bottom of the plotting area or a few pixels higher, unless you're flipping back and forth between the two modes. Sparklines aren't really designed for detailed vertical discrimination -- they're generally intended for showing shapes and trends, not values. I wouldn't recommend zero-anchoring them, but we can still do it if you prefer. 2022-01-122023-04-01 |
All these locations seem fine to me. |
Yeah, I see your point. Okay, let's skip it. Thanks. |
y. I do like it. |
* Switch sparkline length from 4 weeks to 3 months * Switch window length from 4 months to 9 months * Increase visibility of y-axis gridlines * Switch y-axis gridlines from marking weeks to marking months * Add feature descriptions to hexmap legend
b1b31d2
to
6bb20bd
Compare
Summary
Prerequisites:
dev
branchdev
Details
Hex maps
2022-02-01: dark palette
Before:
After, same date, showing greater date range, month grid instead of week grid, more legend labeling:
2023-04-01: light palette
Before:
After, same date, showing greater date range, month grid instead of week grid, more legend labeling:
Line plots
2023-04-01
Before:
After, same date, showing greater date range (but same grid):
Table sparklines
2023-04-01
Before:
After, same date, showing greater date range, month grid instead of week grid: