-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: limit add another to same geo level #628
Conversation
Preview link ready! Built with commit b23f67c https://deploy-preview-628--cmu-delphi-covidcast.netlify.app |
I'm not seeing this work entirely. If I first remove any counties, then when I switch to States, the completion list shows states, but otherwise, it continues to show counties. Same thing in reverse: if any states have been selected, after switching to Counties, it still shows states. If I have both counties and states selected, then counties override states in the decision of what to show. Seems like it should always show whatever is chosen in the "for ..." selector regardless what is currently selected. |
atm the logic is that is shows more of the same. So, if you have selected a state (like Minnesota) it will list more states. If you have selected a county (like Allegheny County) it will list counties. There is no connection to what geo type one has selected in the map. |
I like how this works. I think I found a bug, however:
The text Allegheny County is text repeated in the text field making it awkward to add the next region. |
should be fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks Sam.
closes #624
Prerequisites:
dev
branchdev
Summary
limits the possible items in the add another search box to more of the same level, e.g. here states: