Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: limit add another to same geo level #628

Merged
merged 5 commits into from
Nov 17, 2020
Merged

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 12, 2020

closes #624

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

limits the possible items in the add another search box to more of the same level, e.g. here states:

image

@sgratzl sgratzl requested a review from tildechris November 12, 2020 18:14
@sgratzl sgratzl self-assigned this Nov 12, 2020
@netlify
Copy link

netlify bot commented Nov 12, 2020

Preview link ready!

Built with commit b23f67c

https://deploy-preview-628--cmu-delphi-covidcast.netlify.app

@dlaliberte
Copy link
Contributor

I'm not seeing this work entirely. If I first remove any counties, then when I switch to States, the completion list shows states, but otherwise, it continues to show counties. Same thing in reverse: if any states have been selected, after switching to Counties, it still shows states. If I have both counties and states selected, then counties override states in the decision of what to show. Seems like it should always show whatever is chosen in the "for ..." selector regardless what is currently selected.

@sgratzl
Copy link
Member Author

sgratzl commented Nov 12, 2020

atm the logic is that is shows more of the same. So, if you have selected a state (like Minnesota) it will list more states. If you have selected a county (like Allegheny County) it will list counties. There is no connection to what geo type one has selected in the map.

@tildechris
Copy link
Contributor

I like how this works. I think I found a bug, however:

  • Clear any selected region
  • Go to "Region Details"
  • Search and select "Allegheny County, PA"

The text Allegheny County is text repeated in the text field making it awkward to add the next region.

@sgratzl
Copy link
Member Author

sgratzl commented Nov 17, 2020

I like how this works. I think I found a bug, however:

* Clear any selected region

* Go to "Region Details"

* Search and select "Allegheny County, PA"

The text Allegheny County is text repeated in the text field making it awkward to add the next region.

should be fixed

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Sam.

@sgratzl sgratzl merged commit 00efb85 into dev Nov 17, 2020
@sgratzl sgratzl deleted the sgratzl/filter_addanother branch November 17, 2020 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants