feat: restore focus upon dialog close #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview link ready! Built with commit a8ccd1d https://deploy-preview-630--cmu-delphi-covidcast.netlify.app |
dlaliberte
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Looks good. Works fine.
Though it seems like this should be a feature built-in to a dialog widget. Also, a weird edge case: it can only remember one previous oldFocus, so if you switch from the previously focused thing to yet another thing, it will still restore focus to the previously focused thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #598
Prerequisites:
devbranchdevSummary
restores the old focus upon closing a dialog which forces the focus on the close button.