Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more robust missing meta data handling #653

Merged
merged 2 commits into from
Nov 25, 2020
Merged

more robust missing meta data handling #653

merged 2 commits into from
Nov 25, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 25, 2020

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

improves the handling when no signal meta data is found in the API (e.g, with the current bar visits and other signals), at least it won't break the app anymore.

fixes some race condition in loading the export tab directly

@sgratzl sgratzl self-assigned this Nov 25, 2020
@sgratzl sgratzl requested a review from tildechris November 25, 2020 17:35
@netlify
Copy link

netlify bot commented Nov 25, 2020

Preview link ready!

Built with commit 317be51

https://deploy-preview-653--cmu-delphi-covidcast.netlify.app

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Sam.

@sgratzl sgratzl merged commit e49c55c into dev Nov 25, 2020
@sgratzl sgratzl deleted the sgratzl/invalidsignal branch November 25, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants