Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small map changes #676

Merged
merged 7 commits into from
Dec 9, 2020
Merged

small map changes #676

merged 7 commits into from
Dec 9, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Dec 3, 2020

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

various changes related to the map

  • set a min/maximum zoom level
  • change automatic focus on region logic: only when the user uses the search bar it will focus on the selected region, in all other cases the zoom level of the map won't change automatically anymore.

@sgratzl sgratzl self-assigned this Dec 3, 2020
@netlify
Copy link

netlify bot commented Dec 3, 2020

✔️ Preview link ready!

🔨 Explore the source changes: 25237a8

🔍 Inspect the deploy logs: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/5fc92cf8c145720007e9f806

😎 Browse the preview: https://deploy-preview-676--cmu-delphi-covidcast.netlify.app

@netlify
Copy link

netlify bot commented Dec 3, 2020

Preview link ready!

Built with commit 14b4e4f

https://deploy-preview-676--cmu-delphi-covidcast.netlify.app

Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't notice a big difference in how far you could zoom out, but the level to which you can zoom in looks like an improvement. I also like the automatic focus changes.

@Raphael-Hyde
Copy link
Contributor

LGTM for the zoom-in limit

Also, not seeing the zoom-out limit, thank for sharing @sgratzl

@sgratzl sgratzl merged commit 7874167 into dev Dec 9, 2020
@sgratzl sgratzl deleted the sgratzl/map branch December 9, 2020 14:10
@sgratzl sgratzl mentioned this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants