Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change map style: no county border #712

Merged
merged 2 commits into from
Jan 11, 2021
Merged

change map style: no county border #712

merged 2 commits into from
Jan 11, 2021

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jan 7, 2021 •
edited
Loading

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

image

image

@netlify
Copy link

netlify bot commented Jan 7, 2021

✔️ Preview link ready!

🔨 Explore the source changes: f172e7b

🔍 Inspect the deploy logs: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/5ff74c322babf50007336203

😎 Browse the preview: https://deploy-preview-712--cmu-delphi-covidcast.netlify.app

@sgratzl sgratzl changed the title POV: no county border no county border Jan 7, 2021
@sgratzl sgratzl changed the title no county border change map style: no county border Jan 7, 2021
@sgratzl sgratzl requested a review from tildechris January 7, 2021 20:01
@sgratzl sgratzl self-assigned this Jan 7, 2021
@sgratzl sgratzl marked this pull request as ready for review January 7, 2021 20:01
tildechris
tildechris approved these changes Jan 11, 2021
View reviewed changes
Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this looks a lot better especially at smaller map sizes.

@sgratzl sgratzl merged commit 8445844 into dev Jan 11, 2021
@sgratzl sgratzl deleted the sgratzl/stateborder branch January 11, 2021 14:18
@sgratzl sgratzl mentioned this pull request Jan 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tildechris tildechris tildechris approved these changes

Assignees

@sgratzl sgratzl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sgratzl @tildechris