-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style: change survey parameter style #717
Conversation
✔️ Preview link ready! 🔨 Explore the source changes: 328a363 🔍 Inspect the deploy logs: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/60001243c579270008969f9a 😎 Browse the preview: https://deploy-preview-717--cmu-delphi-covidcast.netlify.app |
Can you make the spacing below the geo search bar match the spacing above? Also, what are your thoughts on selecting all text in the search box when it is focused? I when I go to type in a different geo I found myself typing in the middle of the previous value. I think select-all-on-focus is default behavior in many search boxes. |
fixed |
This is looking great, can you update the spacing between the cal arrows to 36px? Thanks @sgratzl |
Other styling and spacing feedback: Thanks @sgratzl |
it is difficult to create a pixel-perfect match of the design cause
we can take a look at it together in a screenshare session, since in my experience it is faster than applying designs based on screenshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think this version looks and functions well. Thanks.
Thanks for making those updates and sharing the limitations. LGTM! :) |
closes #716
Prerequisites:
dev
branchdev
Summary
current state:
@Letsgohyde take a look, please