Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: change survey parameter style #717

Merged
merged 5 commits into from
Jan 14, 2021
Merged

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Jan 13, 2021

closes #716

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

current state:

image

@Letsgohyde take a look, please

@sgratzl sgratzl requested a review from Raphael-Hyde January 13, 2021 10:15
@sgratzl sgratzl self-assigned this Jan 13, 2021
@netlify
Copy link

netlify bot commented Jan 13, 2021

✔️ Preview link ready!

🔨 Explore the source changes: 328a363

🔍 Inspect the deploy logs: https://app.netlify.com/sites/cmu-delphi-covidcast/deploys/60001243c579270008969f9a

😎 Browse the preview: https://deploy-preview-717--cmu-delphi-covidcast.netlify.app

@tildechris
Copy link
Contributor

Can you make the spacing below the geo search bar match the spacing above?

image

Also, what are your thoughts on selecting all text in the search box when it is focused? I when I go to type in a different geo I found myself typing in the middle of the previous value. I think select-all-on-focus is default behavior in many search boxes.

@sgratzl
Copy link
Member Author

sgratzl commented Jan 13, 2021

selectonclick

@tildechris
Copy link
Contributor

Thanks the spacing and highlighting looks good. For counties without enough data, the "no data available" is above the search bar (z-index issue maybe?):

image

@sgratzl
Copy link
Member Author

sgratzl commented Jan 13, 2021

Thanks the spacing and highlighting looks good. For counties without enough data, the "no data available" is above the search bar (z-index issue maybe?):

fixed

@Raphael-Hyde
Copy link
Contributor

This is looking great, can you update the spacing between the cal arrows to 36px?

image

Thanks @sgratzl

@Raphael-Hyde
Copy link
Contributor

Other styling and spacing feedback:
1.
image
2.
image
3.
image
4.
image

Thanks @sgratzl

@sgratzl
Copy link
Member Author

sgratzl commented Jan 14, 2021

image

it is difficult to create a pixel-perfect match of the design cause

  • the search field has to be compatible with the remaining website, since it is the same widget as in the other views
  • the HTML/DOM hierarchy implied by the implementation makes it tricky to sometimes align items
  • it should work on different screen resolutions

we can take a look at it together in a screenshare session, since in my experience it is faster than applying designs based on screenshots

@tildechris tildechris self-requested a review January 14, 2021 14:01
Copy link
Contributor

@tildechris tildechris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think this version looks and functions well. Thanks.

@sgratzl sgratzl merged commit 7a6c263 into dev Jan 14, 2021
@sgratzl sgratzl deleted the sgratzl/dashboard-changes branch January 14, 2021 16:38
@Raphael-Hyde
Copy link
Contributor

Thanks for making those updates and sharing the limitations. LGTM! :)

@sgratzl sgratzl mentioned this pull request Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Survey dashboard: v2 styling for location and date pickers
3 participants