ci(fix): build images on main push #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for cmu-delphi-main ready! Built with commit c0ac042 |
tildechris
approved these changes
Mar 26, 2021
There was a problem hiding this comment.
LGTM. I see the version tagged image at https://github.com/orgs/cmu-delphi/packages/container/package/www-main.
FYI @kateharwood you will probably want to do something similar in forecast-eval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the new automated behavior a new tag won't trigger the CI. Thus, I changed the logic to build the image on main/dev and also push the tag/version name as an alias to the main/latest docker tag.