Skip to content

Conversation

carlynvandyke
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Jan 6, 2023

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit 6985914
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/63d2bdcb9c15cf00070d8ec5
😎 Deploy Preview https://deploy-preview-755--cmu-delphi-main.netlify.app/blog/2022/12/14/introducing-epidata-v4
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@minhkhul minhkhul requested a review from krivard January 20, 2023 19:48
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions for both @carlynvandyke and @minhkhul

Also I need to update my author blurb, it's out of date. I'll push up a commit for that.

minhkhul and others added 3 commits January 23, 2023 15:25
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
Co-authored-by: Katie Mazaitis <krivard@cs.cmu.edu>
@minhkhul minhkhul requested a review from krivard January 24, 2023 19:19
@melange396
Copy link
Contributor

for reference, the gdocs draft is here

@melange396
Copy link
Contributor

is there a way to do fixed-width fonts on this?

@melange396
Copy link
Contributor

i pushed changes for other fixed-width stuff that i thought was appropriate, but im not married to it if there are objections. with or without that, this looks good to me (modulo regenerating the html, of course)

@melange396
Copy link
Contributor

ugh... looking at the netlify preview linked above, it seems spaces inside of fixed-width text (or <code> tags in the html) are non-breaking, so all of each segment of f-w text will get displayed on a single line, which screws up our paragraph structure (and i think it looks stupid) :

image

i previewed doing a split of the f-w around spaces (by doing a manual/live edit of the elements) and think it looks better this way:

image

in a few minutes, ill push an update to this branch to fix that.

@minhkhul
Copy link
Contributor

Made commas and parenthesis not fixed width for clarity.
Screenshot 2023-01-26 at 12 53 00 PM

@melange396
Copy link
Contributor

i kinda liked having the parens in red too because it made the tuple look like a whole "unit", and with regular parens it looks like its an aside instead. on the other hand, at this point, im fine with whatever... ¯\_(ツ)_/¯

Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krivard krivard merged commit 4892e4a into dev Jan 27, 2023
@krivard krivard deleted the krivard/blog-tests-more branch January 27, 2023 20:15
@krivard krivard mentioned this pull request Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants