Skip to content

Conversation

christymelucci
Copy link
Contributor

@christymelucci christymelucci commented Feb 10, 2023

Update Team Page with changes resulting from spring 2023 resource access review

George -> CMU/MLD
Logan -> University of California, Berkeley
Ryan -> University of California, Berkeley and CMU/MLD
Maggie -> Past
Leon -> Contributors
University California, Berkeley -> UC Berkeley
EJ -> Add months
Ryan -> UC Berkeley/Stat and CMU/MLD
Alden -> Stanford University/Stat
Andrew -> Johns Hopkins/Biostat
Kean Ming -> Contributors
@netlify
Copy link

netlify bot commented Feb 10, 2023

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit cda6a90
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/63f3fe00aec686000856244b
😎 Deploy Preview https://deploy-preview-767--cmu-delphi-main.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Ruiqi Lyu -> Core
Santiago Cortes Gomez -> Contributors
Jeremy Goldwasser -> Core Members
Tianyue Zhou -> Contributors
Xueda Shen -> Core Members
Photo file will be replaced with higher res image shorlty
Remove: 
'note: Contributor, June-December 2021'
retain for info use when she not currently working as a Contributor
Copy link
Contributor

@krivard krivard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (optional): obscure note instead of removing it

but I don't feel strongly about it if you're more comfortable tracking that information elsewhere.

@@ -377,7 +390,6 @@ people:
lastName: Lakdawala
image: tarannum-lakdawala.jpeg
affiliation: CMU/CSD
note: Contributor, June-December 2021
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight preference for changing the field name to something that will be ignored by the frontend instead of deleting this information. For example:

  future_note: Contributor, June-December 2021, September 2022-TBD

(i tested this out and it works)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion. Agree.

'future_note:' 
-ignored by the fronted
-includes text for use in 'note:' in the future
@christymelucci christymelucci changed the title Update Team Page update team page Feb 20, 2023
@christymelucci christymelucci merged commit a44d6f1 into dev Feb 20, 2023
@christymelucci christymelucci deleted the cmelucci/team-page-update branch February 20, 2023 23:19
@krivard krivard mentioned this pull request Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants