Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blog photos update #913

Merged
merged 7 commits into from
Jan 29, 2024
Merged

Conversation

Ananya-Joshi
Copy link
Contributor

The blog photos weren't like the others so I updated them based on Carlyn's suggestion!

Copy link

netlify bot commented Jan 26, 2024

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit 19e71ff
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/65b7d7d3f6e756000862c11f
😎 Deploy Preview https://deploy-preview-913--cmu-delphi-main.netlify.app/blog/2023/12/20/exploratory-analysis-identifying-changing-variant-behavior-during-a-pandemic
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are much prettier images! a couple comments though...

content/blog/images/changepoint-hero.jpg Show resolved Hide resolved
content/blog/images/old-changepoint-blog.png Outdated Show resolved Hide resolved
content/blog/images/old-changepoint-hero.png Outdated Show resolved Hide resolved
Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@melange396 melange396 merged commit cb1586e into cmu-delphi:dev Jan 29, 2024
5 checks passed
@melange396
Copy link
Contributor

@Ananya-Joshi : i just noticed this... i didnt think it was the case before, but something mightve changed with your force-push ¯\_(ツ)_/¯

you should delete https://github.com/cmu-delphi/www-main/blob/dev/content/blog/images/flash_long.png and https://github.com/cmu-delphi/www-main/blob/dev/content/blog/images/flash_logo.png since theyre no longer being referenced

@melange396
Copy link
Contributor

actually, never mind, we can delete them in #914

Ananya-Joshi added a commit to Ananya-Joshi/www-main that referenced this pull request Feb 5, 2024
* changed hero and thumb photos to Carlyn's recommendations

* remove spaces

* rename image files

* changed proportions on flash_hero img
This was referenced Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants