-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Delphi website carousel #924
Conversation
✅ Deploy Preview for cmu-delphi-main ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Will leave for Ron and George to take a look.
Thanks - that looks good. We may want to make more changes to names (pending feedback from Roni and others) but this looks like a good first step! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a more meaningful file name that's similar to the other file names in that directory might be: "landing-pg-hero-introducing_epidata.jpg"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think a more meaningful file name that's similar to the other file names in that directory might be: "landing-pg-hero-exploratory_analysis.jpg"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought about it a bit more, and while the image files in that folder aren't very consistent in naming format, we could choose file names that match the text that people see (see comments on the image files).
Looks good - thanks! |
title: An Open Repository of Real-Time COVID-19 Indicators | ||
link: https://delphi.cmu.edu/blog/2022/12/14/introducing-epidata-v4/ | ||
alt: Introducing Epidata |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This title isnt appropriate because the article is not at all COVID specific... And then do we want to move this one slot closer to the beginning of the carousel (in front of the COVID-titled article)?
title: An Open Repository of Real-Time COVID-19 Indicators | |
link: https://delphi.cmu.edu/blog/2022/12/14/introducing-epidata-v4/ | |
alt: Introducing Epidata | |
title: Introducing Epidata | |
link: https://delphi.cmu.edu/blog/2022/12/14/introducing-epidata-v4/ | |
alt: View Post |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch! I do think that moving it closer to the beginning is a good idea, too.
Implements the changes to the website carousel requested in https://cmu-delphi.atlassian.net/browse/OKRS24-8