Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 #928

Merged
merged 6 commits into from
Feb 16, 2024
Merged

Patch 1 #928

merged 6 commits into from
Feb 16, 2024

Conversation

dajmcdon
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for cmu-delphi-main ready!

Name Link
🔨 Latest commit b5f6464
🔍 Latest deploy log https://app.netlify.com/sites/cmu-delphi-main/deploys/65cfe5179917de00085630a4
😎 Deploy Preview https://deploy-preview-928--cmu-delphi-main.netlify.app/about/publications
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@melange396 melange396 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but i had one question about older the updated paper...

year: 2022
link: https://doi.org/10.1080/10618600.2023.2285337
journal: Journal of Computational and Graphical Statistics
year: 2024
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you want to move this to the top to preserve the reverse chronological ordering by publication date, or leave it here because of the original arxiv date?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine either way. These things take so long that it might be annoying to constantly bump stuff to the top. But if someone else likes the chronology, I don't mind.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think you should, both for my OCD and to highlight the fact that its been properly published.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. And fixed my earlier deletion of Ananya's IJCAI paper info.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think you actually deleted anything from her paper's entry... It was previously missing the year. The diff from your first commit shows an invisible change on line 8, which i think was just something with extra trailing whitespace or a funny newline character. We should leave the year that you added though; i created an issue for it a few hours ago, and Ananya can update the date later if necessary.

@melange396 melange396 merged commit d08134f into cmu-delphi:dev Feb 16, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants