-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 #928
Patch 1 #928
Conversation
✅ Deploy Preview for cmu-delphi-main ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, but i had one question about older the updated paper...
content/about/publications/index.md
Outdated
year: 2022 | ||
link: https://doi.org/10.1080/10618600.2023.2285337 | ||
journal: Journal of Computational and Graphical Statistics | ||
year: 2024 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you want to move this to the top to preserve the reverse chronological ordering by publication date, or leave it here because of the original arxiv date?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine either way. These things take so long that it might be annoying to constantly bump stuff to the top. But if someone else likes the chronology, I don't mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think you should, both for my OCD and to highlight the fact that its been properly published.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. And fixed my earlier deletion of Ananya's IJCAI paper info.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think you actually deleted anything from her paper's entry... It was previously missing the year. The diff from your first commit shows an invisible change on line 8, which i think was just something with extra trailing whitespace or a funny newline character. We should leave the year that you added though; i created an issue for it a few hours ago, and Ananya can update the date later if necessary.
No description provided.