Fix #269, adminSettings.json dependent on compilation order #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing get_admin_settings will cause the file to get generated in case those files are run before settings.js
jacksontromero
changed the title
|
Tested on my end by deleting adminSettings.json and saw that the server successfully recreated upon starting. LGTM, but let me know if there's any other tests I should do. |
csuraparaju
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #269 by having get_admin_settings create the json file if it doesn't already exist
Also removes potential problem where the relative path wasn't dependent on dirname and so adminSettings.json could be in different places depending on how the server was invoked.