ci: adjust Pyodide deps and retrieve prebuilt artifacts #744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
needed as we use version 2+ and the official pyodide recipe maintains v `1.10.7`
Required as we need to compile Rust to WASM
required by `pydantic`
This should reduce CI time drastically
It is only used in the `web` group
Previously we marked packages as built when they appeared as dependencies, even though the package was meant to get built from source.
domoritz
approved these changes
Oct 22, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| def load_recipe(package_name: str) -> Recipe | None: | ||
| path = get_recipe_path(package_name) | ||
| try: | ||
| return yaml.safe_load(open(path)) |
Check warning
Code scanning / CodeQL
File is not always closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dependency Adjustments
This is caused by a regression introduced in #673 after we migrated to Pydantic 2: we migrated the pure-python project dependency, but not the Pyodide dependency.
We should add some tests around our WASM distribution soon.
To support Pydantic 2 in Pyodide I had to add Rust as a dependency to the Pyodide build environment, as https://github.com/pydantic/pydantic-core is written in Rust.
Using prebuilt artifacts in CI
Our latest Pyodide distribution is always hosted under https://dig.cmu.edu/draco2/jupyterlite/static/pyodide. Instead of rebuilding each artifact each time, we can do a diffing based on
meta.yamlPyodide recipe filesThis simple idea is implemented in
pyodide/cache_dl.py.Post-PR Results