Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a simple language model maker script #405

Merged
merged 4 commits into from
Jan 10, 2025
Merged

Add a simple language model maker script #405

merged 4 commits into from
Jan 10, 2025

Conversation

lenzo-ka
Copy link
Contributor

No description provided.

@lenzo-ka lenzo-ka requested a review from dhdaines December 11, 2024 15:06
@dhdaines
Copy link
Contributor

Ah, this is good, probably a lot of people would like to make a simple LM without having to install KenLM or some other package with more onerous requirements. I will try it out / test it tomorrow. Thanks!

@lenzo-ka
Copy link
Contributor Author

lenzo-ka commented Jan 7, 2025

Any thoughts on this @dhdaines ?

@dhdaines
Copy link
Contributor

dhdaines commented Jan 8, 2025

Ah, yes! The day I thought I would spend catching up PocketSphinx stuff I spent ... doing something else (probably parsing PDFs). It does look good, I promise I will approve/merge it soon!

@dhdaines
Copy link
Contributor

Just made a couple of tweaks to this - at the very least it should do something helpful when called with no arguments, so I changed that, and made use of argparse.FileType so you can call it with --sentfile - to get input from standard input. Also ran black and isort on the code for consistent formatting.

@dhdaines dhdaines merged commit 00486b3 into master Jan 10, 2025
21 checks passed
@dhdaines dhdaines deleted the arpabo-lm branch January 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants