Update pane initialization and display logic

[amcgee]

Allow initially-hidden non-collapsible panes, sanitize togglePane 'show' parameter, and publish a subscribable event when toggling a pane. This allows for better declarative configuration without needing to utilize CSS properties or javascript callbacks.

Note : setting "open: false" still causes the sidebar to flash before disappearing. This is because the initial CSS is still set to display 'block'. To fix this, the pane initialization function would need to modify the CSS of the sidebar before it is rendered.

[tmcgee]

@amcgee Please merge the new changes from the cmv-app develop branch and then I will merge in your enhancement. Thanks!

[amcgee]

Updated, thanks!

[green3g]

This seems to be causing a problem. When a pane is toggled via a collapse button it no longer works. It looks like line 182 will send the key, and the domEvent as a second argument.

on(this.collapseButtons[key], 'click', lang.hitch(this, 'togglePane', key));

The new logic doesn't check for this, and throws an error.

See my comment in the Files Changed tab

[green3g]

Need to replace this error message with this:

newDisp =(domStyle.get(domNode, 'display') === 'none') ? 'block' : 'none';

[amcgee]

Good catch, thanks @roemhildtg! While accepting any type of 'show' argument and toggling if it isn't a display CSS string or boolean would work, another fix is to update the Toggle handler to call togglePane with three explicit arguments so we get togglePane(key, null, false, ). That keeps the togglePane API as strict as possible. I will open a separate pull request for discussion about that approach. EDIT: I'll comment on the PR you opened.