Enable force destroy for s3 log bucket #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created a new variable log_bucket_force_destroy Pass the value of this to s3_logs_bucket module Update readme with doc changes
jnonino
approved these changes
Nov 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When running
terraform destroythe S3 buckets need to be empty to properly complete. Force deletion is already supported for the website bucket usingwebsite_bucket_force_destroy = truebut the log bucket will still prevent destruction. The added input will allow configuration for the logging bucket to also be force deleted when it is not empty.Changes
log_bucket_force_destroyvariable, defaulted tofalses3_bucket_force_destroyfrom cn-terraform/logs-s3-bucket/awsNotes
This is my first PR to a Terraform module, please let me know if there is anything else that would be needed for these changes. Thanks!