Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #382 and #210: NDN protocol interest lifetime #383

Merged
merged 2 commits into from
Mar 28, 2021
Merged

fix #382 and #210: NDN protocol interest lifetime #383

merged 2 commits into from
Mar 28, 2021

Conversation

MahdiBaghbani
Copy link
Contributor

@MahdiBaghbani MahdiBaghbani commented Mar 28, 2021 •
edited
Loading

This pull request contains:

  1. A follower commit to complete original commit 92e797e fix for NDN protocol interest lifetime issues NDN interest life time is wrong #382 and interest lifetime is encoded as seconds in ccnl_interest_new #210.
  2. Adding comment on my previous merge request code explaining why the if block should compare value to -1

blacksheeep
blacksheeep approved these changes Mar 28, 2021
View reviewed changes
Copy link
Contributor

@blacksheeep blacksheeep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for investigating and fixing

@blacksheeep blacksheeep merged commit da0d9de into cn-uofbasel:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blacksheeep blacksheeep blacksheeep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MahdiBaghbani @blacksheeep