Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(bundle.go): add DeepCopy for InvocationImage/BaseImage/Image #143

Merged
merged 1 commit into from
Oct 14, 2019
Merged

feat(bundle.go): add DeepCopy for InvocationImage/BaseImage/Image #143

merged 1 commit into from
Oct 14, 2019

Conversation

vdice
Copy link
Member

@vdice vdice commented Oct 8, 2019

Adds a DeepCopy method on a BaseImage struct, used also for DeepCopy methods for the InvocationImage and Image structs.

@vdice vdice force-pushed the feat/img-deep-copy branch 2 times, most recently from 21edb7a to 7f09662 Compare October 8, 2019 17:43
@vdice vdice mentioned this pull request Oct 9, 2019
Merged
6 tasks
@vdice vdice force-pushed the feat/img-deep-copy branch from 7f09662 to 94abc35 Compare October 10, 2019 22:17
@vdice
Copy link
Member Author

vdice commented Oct 10, 2019

(subsequent forced-pushed commit just to rebase w/ master)

jeremyrickard
jeremyrickard approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@jeremyrickard jeremyrickard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeremyrickard jeremyrickard merged commit a1f17dc into cnabio:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyrickard jeremyrickard jeremyrickard approved these changes

@glyn glyn glyn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vdice @glyn @jeremyrickard