-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update version.rs segfault and WithAutoRefresh rename #39
Conversation
Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
1d2f780
to
3a01b8c
Compare
@ChengyuZhu6 @Apokleos PTAL |
…t we cannot use Option is a reserved keyword Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
5b973eb
to
2090a19
Compare
Fixes: #40 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @zvonkok
Just one comment left to discuss introducing Cache::new(auto_refresh:bool) {}
9c88984
to
68d7e6b
Compare
Signed-off-by: Zvonko Kaiser <zkaiser@nvidia.com>
f8a2bd8
to
d325c31
Compare
@Apokleos Also fixed a bug with edits, what we missed is that we might only have dev.edits and if spec.edits is None it will skip adding the dev.edits here is an example
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should first fix related issues and make it merged. LGTM!
Initialize Cache with auto_refresh true according to CDI go-implRename WithAutoRefresh and adjust to CdiOption.
Updated version.rs to not panic