reconsider dependencies #97
Labels
Comments
8 tasks
|
Filed this issue for runtime-tools, describing the problem and telling that we're (as in the folks from Intel and Nvidia working on DRA and CDI) ready to do the actual heavy lifting as long as we can agree with the runtime-tools maintainers about what is acceptable lifting. |
bart0sh
added a commit
to bart0sh/container-device-interface
that referenced
this issue
Oct 26, 2023
This should allow to import CDI spec structures without adding a lot of CDI runtime deps. It should partly fix cncf-tags#97 and allow Kubernetes to refer this module directly. There are at least 2 places in the k/k codebase that would benefit from this change: - this can be replaced by the specs-go import: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/app/cdi.go - this can import specs-go and use JSON marshalling instead of quite ugly approach it uses to write CDI files: https://github.com/kubernetes/kubernetes/blob/master/test/images/sample-device-plugin/sampledeviceplugin.go#L237
Merged
bart0sh
added a commit
to bart0sh/container-device-interface
that referenced
this issue
Oct 26, 2023
This should allow to import CDI spec structures without adding a lot of CDI runtime deps. It should partly fix cncf-tags#97 and allow Kubernetes to refer this module directly. There are at least 2 places in the k/k codebase that would benefit from this change: - this can be replaced by the specs-go import: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/app/cdi.go - this can import specs-go and use JSON marshalling instead of quite ugly approach it uses to write CDI files: https://github.com/kubernetes/kubernetes/blob/master/test/images/sample-device-plugin/sampledeviceplugin.go#L237 Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
bart0sh
added a commit
to bart0sh/container-device-interface
that referenced
this issue
Oct 26, 2023
This should allow to import CDI spec structures without adding a lot of CDI runtime deps. It should partly fix cncf-tags#97 and allow Kubernetes to refer this module directly. There are at least 2 places in the k/k codebase that would benefit from this change: - this can be replaced by the specs-go import: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/app/cdi.go - this can import specs-go and use JSON marshalling instead of quite ugly approach it uses to write CDI files: https://github.com/kubernetes/kubernetes/blob/master/test/images/sample-device-plugin/sampledeviceplugin.go#L237 Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
bart0sh
added a commit
to bart0sh/container-device-interface
that referenced
this issue
Oct 27, 2023
This should allow to import CDI spec structures without adding a lot of CDI runtime deps. It should partly fix cncf-tags#97 and allow Kubernetes to refer this module directly. There are at least 2 places in the k/k codebase that would benefit from this change: - this can be replaced by the specs-go import: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/app/cdi.go - this can import specs-go and use JSON marshalling instead of quite ugly approach it uses to write CDI files: https://github.com/kubernetes/kubernetes/blob/master/test/images/sample-device-plugin/sampledeviceplugin.go#L237 Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
elezar
pushed a commit
to bart0sh/container-device-interface
that referenced
this issue
Oct 30, 2023
This should allow to import CDI spec structures without adding a lot of CDI runtime deps. It should partly fix cncf-tags#97 and allow Kubernetes to refer this module directly. There are at least 2 places in the k/k codebase that would benefit from this change: - this can be replaced by the specs-go import: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/dra/test-driver/app/cdi.go - this can import specs-go and use JSON marshalling instead of quite ugly approach it uses to write CDI files: https://github.com/kubernetes/kubernetes/blob/master/test/images/sample-device-plugin/sampledeviceplugin.go#L237 Signed-off-by: Ed Bartosh <eduard.bartosh@intel.com>
|
This issue is stale because it has been open 90 days with no activity. This issue will be closed in 30 days unless new comments are made or the stale label is removed. |
|
This issue was automatically closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Using this repository is not possible in Kubernetes because even just having problematic dependencies in the dependency graph is flagged as a problem, even if no code from those dependencies is needed in Kubernetes:
The solution I came up with for now consists of copying some code from this repo into Kubernetes:
Long term it would be good to have that code in a Go module with no problematic dependencies.
This can be done by splitting this repo or with multiple Go modules in the existing one.
The text was updated successfully, but these errors were encountered: