Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed release-note-none label from dependabot #125

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

elezar
Copy link
Contributor

@elezar elezar commented Mar 15, 2023

The dependabot PRs created fail due to a missing label.

This PR removes the setting.

An alternative would be to add the label to the project.

See for example: #124 (comment)

Signed-off-by: Evan Lezar <elezar@nvidia.com>
@elezar elezar requested review from bart0sh and klihub March 15, 2023 12:58
Signed-off-by: Evan Lezar <elezar@nvidia.com>
open-pull-requests-limit: 10
ignore:
- versions: ["*-rc.*"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure whether thsi will have the intended effect. I would like to avoid version updates such as #123.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's try it out and adjust as/if necessary.

Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@klihub klihub merged commit fca2154 into cncf-tags:main Mar 15, 2023
@elezar elezar deleted the dont-set-label-on-dependabot branch March 21, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants