Move parsing and name validation to cdi/parse package #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elezar
force-pushed
the
better-is-qualified-name
branch
2 times, most recently
from
a709266
to
8ea61a7
Compare
elezar
force-pushed
the
better-is-qualified-name
branch
3 times, most recently
from
35799bc
to
2fb1ea1
Compare
elezar
force-pushed
the
better-is-qualified-name
branch
from
2fb1ea1
to
aa1fd48
Compare
klihub
reviewed
Mar 24, 2023
pkg/cdi/qualified-device.go
Outdated
| } | ||
|
|
||
| // ParseQualifiedName splits a qualified name into device vendor, class, | ||
| // and name. If the device fails to parse as a qualified name, or if any | ||
| // of the split components fail to pass syntax validation, vendor and | ||
| // class are returned as empty, together with the verbatim input as the | ||
| // name and an error describing the reason for failure. | ||
| // | ||
| // Deprecated: use parser.Interface.ParseQualifiedName instead |
There was a problem hiding this comment.
Shouldn't this be use parser.ParseQualifiedName without .Interface. ?
klihub
reviewed
Mar 24, 2023
pkg/cdi/qualified-device.go
Outdated
| } | ||
|
|
||
| // ParseDevice tries to split a device name into vendor, class, and name. | ||
| // If this fails, for instance in the case of unqualified device names, | ||
| // ParseDevice returns an empty vendor and class together with name set | ||
| // to the verbatim input. | ||
| // | ||
| // Deprecated: use parser.Interface.ParseDevice instead |
klihub
reviewed
Mar 24, 2023
pkg/cdi/qualified-device.go
Outdated
| // If parsing fails, an empty vendor and the class set to the | ||
| // verbatim input is returned. | ||
| // | ||
| // Deprecated: use parser.Interface.ParseQualifier instead |
klihub
requested changes
Mar 24, 2023
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Thanks. Missed updating the comments in my various iterations. |
elezar
force-pushed
the
better-is-qualified-name
branch
from
aa1fd48
to
e53d516
Compare
|
@klihub thanks for the review. Updated. |
klihub
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow golang dependencies to be better managed.
See docker/cli#4084 (review)