log the unresolved CDI devices only #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariq1890
force-pushed
the
unres-devs-log
branch
4 times, most recently
from
d6c7b8d
to
7ba5323
Compare
|
And some bonus changes to get the CI to play nice with me |
tariq1890
force-pushed
the
unres-devs-log
branch
from
7ba5323
to
8e1ef87
Compare
Signed-off-by: Tariq Ibrahim <tibrahim@nvidia.com>
tariq1890
force-pushed
the
unres-devs-log
branch
from
8e1ef87
to
a446fd5
Compare
tariq1890
commented
Aug 10, 2023
|
@klihub would you be able to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
InjectDevices()we are currently error-logging the whole list of devices instead of the device handles which weren't resolved