Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.github, Makefile: sanity workflow fixes, simplify mod-* targets, bump golang to 1.19.x #171

Merged
merged 6 commits into from
Oct 27, 2023
Merged

.github, Makefile: sanity workflow fixes, simplify mod-* targets, bump golang to 1.19.x #171

merged 6 commits into from
Oct 27, 2023

Conversation

klihub
Copy link
Contributor

@klihub klihub commented Oct 26, 2023

This PR

  • simplifies go.{mod,sum} tidying and fixes existing deviations from tidy go mods
  • fixes the existing gofmt check in the sanity workflow and existing gofmt violations in the code
  • adds go mod tidiness verification to the sanity workflow
  • bumps go version to 1.19.x everywhere
  • updates go deps

@klihub
Makefile: simplify mod-{tidy,verify} targets.
46326e8 
Simplify go.mod tidying and verifying. Switch from explicit
hand-crafted targets for handling submodules to discovering
and handling them automatically.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from elezar October 26, 2023 17:09
@klihub klihub mentioned this pull request Oct 26, 2023
Merged
elezar
elezar reviewed Oct 27, 2023
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the simplification @klihub.

One minor question on the sanity workflow, but otherwise this looks good.

.github/workflows/sanity.yml Outdated Show resolved Hide resolved
@klihub
.github: verify go.{mod,sum}s are up-to-date.
93f75c9 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
go.mod,.github: bump go version to 1.19
dce4d26 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
go.{mod,sum}: update deps.
3155c24 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
.github: fix gofmt workflow.
e89823f 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub
pkg,internal: fix gofmt errors.
d5466c6 
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@bart0sh
Copy link
Contributor

bart0sh commented Oct 27, 2023

/lgtm

@klihub klihub requested a review from elezar October 27, 2023 16:13
elezar
elezar approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@elezar elezar merged commit 2cff845 into cncf-tags:main Oct 27, 2023
7 checks passed
@klihub klihub deleted the fixes/sanity-workflow branch October 30, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh bart0sh left review comments

@elezar elezar elezar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@klihub @bart0sh @elezar