Use tags.cncf.io URL in module names #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
klihub
reviewed
Oct 31, 2023
| @@ -48,7 +48,7 @@ | |||
| // | |||
| // log "github.com/sirupsen/logrus" | |||
| // | |||
| // "github.com/container-orchestrated-devices/container-device-interface/pkg/cdi" | |||
| // "tags.cncf.io/container-device-interface/pkg/cdi" | |||
There was a problem hiding this comment.
nitpick: I would also do on line 5 an 's:/container-orchestrated-devices/:/cncf-tags/'
klihub
requested changes
Oct 31, 2023
There was a problem hiding this comment.
Although this is not strictly necessary from the code point of view, for consistency I would also consider updating these remaining old '/container-orchestrated-devices/' repo references to the new '/cncf-tags/' one, while we're at it. @elezar WDYT ?
klitkey1-mobl1 container-device-interface $ git grep -n container-orchestrated-devices
README.md:3:**NOTE:** The API for injecting CDI devices that existed at `github.com/container-orchestrated-devices/container-device-interface/pkg` has been removed. Users of this API should migrate to the one at `github.com/container-orchestrated-devices/container-device-interface/pkg/cdi` as this is actively maintained.
README.md:191:* Please let us know by [filing a new issue](https://github.com/container-orchestrated-devices/container-device-interface/issues/new)
pkg/cdi/doc.go:5:// https://github.com/container-orchestrated-devices/container-device-interface
|
/cc @bart0sh |
klihub
reviewed
Oct 31, 2023
There was a problem hiding this comment.
@elezar Sorry, I don't want to be a PITA, but I still see two references of the old repo. Is this intentional:
klitkey1-mobl1 container-device-interface $ git grep -n container-orchestrated-devices
README.md:3:**NOTE:** The API for injecting CDI devices that existed at `github.com/container-orchestrated-devices/container-device-interface/pkg` has been removed. Users of this API should migrate to the one at `tags.cncf.io/container-device-interface/pkg/cdi` as this is actively maintained.
README.md:191:* Please let us know by [filing a new issue](https://github.com/container-orchestrated-devices/container-device-interface/issues/new)
Signed-off-by: Evan Lezar <elezar@nvidia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With cncf/toc#1152 addressed, we are able to use the
tags.cncf.iovanity URL in our module names.