Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add a pointer to community meetings in our docs. #210

Merged
merged 2 commits into from
Jul 5, 2024

Conversation

klihub
Copy link
Contributor

@klihub klihub commented Jun 25, 2024

Add a section to the docs about community meetings and a pointer to the CNCF calendar with meeting details.

@klihub klihub requested a review from elezar June 25, 2024 16:35
@klihub
Copy link
Contributor Author

klihub commented Jun 27, 2024

/cc @bart0sh

CONTRIBUTING.md Outdated
details in the [CNCF Community Meetings Calendar](https://www.cncf.io/calendar).
The calendar entry also has a link to our community meeting agenda. The agenda
has a summary of past meeting topics and discussions. It can also be freely
edited by anyone to propose topics for upcoming meetings.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also mention the name of the meeting as it shown at the link [CNCF TAG Runtime Container Device Interface (COD) Working Group](https://tockify.com/cncf.public.events/detail/184/1719324000000?search=COD)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing to the meeting notes https://docs.google.com/document/d/1gUgAMEThkRt4RJ7pA7ZbPPmIOX2Vb7fwH025MjfcTYU would also make sense, I think.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this and decided to deliberately not link directly to the meeting agenda, but instead mention that it is reachable via an up-to-date link through the meeting calendar entry. This way we don't need to worry about keeping the meeting agenda link up to date in the documentation if it ever changes.

And thanks for the tockify hint/link. I added now your suggested search link to our docs, so getting to the calendar should now be behind two clicks, the agenda behind 3 clicks, and no manual searching any more.

Add a note about community meetings and a pointer to the CNCF
calendar for up-to-date meeting details and agenda.

Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
@klihub klihub requested a review from bart0sh June 29, 2024 10:11
Copy link
Contributor

@bart0sh bart0sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

If you set your `user.name` and `user.email` git configs, you can sign your
commit automatically with `git commit -s`.
If you set your `user.name` and `user.email` in your git config, you can
sign your commit automatically with `git commit -s`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: I think it's sign-off. Sign implies the use of PGP keys for verified commits.

Copy link
Contributor

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit, but it looks good!

@elezar elezar merged commit ff280d6 into cncf-tags:main Jul 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants