Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: update opencontainers packages #87

Closed
wants to merge 1 commit into from

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Oct 27, 2022

The update runtime-tools contain
opencontainers/runtime-tools#755 and thus CDI will have less dependencies when only used to write files without validation.

I have verified that this removes github.com/blang/semver and github.com/xeipuuv from Kubernetes,
Fixes: #80

@elezar
Copy link
Contributor

elezar commented Nov 1, 2022

@pohly please sign the commit to pass the DCO check.

The update runtime-tools contain
opencontainers/runtime-tools#755 and thus CDI will have
less dependencies when only used to write files without validation.

Signed-off-by: Patrick Ohly <patrick.ohly@intel.com>
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@klihub klihub self-requested a review November 7, 2022 09:20
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test cross-build error is due to a stupid thinko that slipped through in opencontainers/runtime-tools#755.
Fixed in opencontainers/runtime-tools#757. Let's wait for that to get merged...

@klihub
Copy link
Contributor

klihub commented Nov 11, 2022

Closing, rebased as #100

@klihub klihub closed this Nov 11, 2022
bart0sh added a commit that referenced this pull request Nov 11, 2022
dependencies: update opencontainers packages (rebased #87)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependencies: github.com/xeipuuv pulled into Kubernetes
3 participants