Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Microservices demo #13

Merged
merged 7 commits into from
Jan 31, 2024
Merged

Microservices demo #13

merged 7 commits into from
Jan 31, 2024

Conversation

AntonioDiTuri
Copy link
Contributor

No description provided.

@dipankardas011
Copy link
Contributor

dipankardas011 commented Dec 13, 2023 •
edited
Loading

Overview details

This PR contains the usage of https://fluxcd.io/flux/cheatsheets/oci-artifacts/#helm-oci
for helm-oci (for microservice-demo by google) deploy using flux

@incertum incertum mentioned this pull request Dec 19, 2023
Closed
rossf7
rossf7 reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AntonioDiTuri This looks good and OCI FTW!

Just some minor changes to align with what we used for kepler in #5

clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
@nikimanoledaki nikimanoledaki mentioned this pull request Jan 10, 2024
Closed
7 tasks
@AntonioDiTuri
Copy link
Contributor Author

Will update the pull request asap

@AntonioDiTuri
Copy link
Contributor Author

I committed all the requested changes, can we close this? @rossf7 I requested your review :)

nikimanoledaki
nikimanoledaki approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some requested changes then LGTM 🥳

clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
clusters/microservices-demo.yaml Outdated Show resolved Hide resolved
@AntonioDiTuri
all the commits need to be signed, adding the microservices-demo config
bb4fc19 
Signed-off-by: Antonio Di Turi <anto.dituri@gmail.com>
@AntonioDiTuri
Copy link
Contributor Author

@rossf7 I adjusted the changes, please let me know if something else need to be reviewed

rossf7
rossf7 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted the changes, please let me know if something else need to be reviewed

@AntonioDiTuri This looks good just needs the namespace change suggested by Niki here https://github.com/cncf-tags/green-reviews-tooling/pull/13/files#r1471463552

nikimanoledaki
nikimanoledaki approved these changes Jan 31, 2024
View reviewed changes
clusters/projects/falco/microservices-demo.yaml Outdated Show resolved Hide resolved
clusters/projects/falco/microservices-demo.yaml Outdated Show resolved Hide resolved
docs/microservices_demo.md Outdated Show resolved Hide resolved
docs/microservices_demo.md Outdated Show resolved Hide resolved
clusters/projects/falco/microservices-demo.yaml Outdated Show resolved Hide resolved
@nikimanoledaki nikimanoledaki merged commit 14a057f into cncf-tags:main Jan 31, 2024
1 check passed
@nikimanoledaki
Copy link
Contributor

Apologies for my slightly messy additions... 😅 Just wanted to merge this! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

@rossf7 rossf7 rossf7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AntonioDiTuri @dipankardas011 @nikimanoledaki @rossf7