Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal 1: Trigger and Deploy #88

Merged
merged 21 commits into from
May 30, 2024
Merged

Proposal 1: Trigger and Deploy #88

merged 21 commits into from
May 30, 2024

Conversation

dipankardas011
Copy link
Contributor

@dipankardas011 dipankardas011 commented Apr 16, 2024 •
edited
Loading

What type of PR is this?

kind/documentation

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #84

Special notes for your reviewer (optional):

cc @rossf7

@dipankardas011
feat(proposal): initial proposal for trigger and deploy
433b9e2 
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@dipankardas011 dipankardas011 mentioned this pull request Apr 16, 2024
Closed
5 tasks
rossf7
rossf7 reviewed Apr 17, 2024
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start 👍 first round of feedback from me

docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
dipankardas011 and others added 2 commits April 17, 2024 23:51
@dipankardas011
refactor(proposal): improved the missing parts in the proposal
e1cf8bd 
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@dipankardas011 @rossf7
feat(proposal): added proposal section for trigger and deploy proposal
9f9e08b 
Co-authored-by: Ross Fairbanks <ross@rossfairbanks.com>
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
rossf7
rossf7 reviewed Apr 18, 2024
View reviewed changes
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
dipankardas011 and others added 3 commits April 18, 2024 17:44
@dipankardas011
feat: added fixes to the proposal structure
5d08461 
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@rossf7
feat: Extend trigger and deploy proposal
1aa8695 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@dipankardas011
Merge pull request #1 from dipankardas011/feat-extend-proposal
503283f 
feat: Extend trigger and deploy proposal
@dipankardas011 dipankardas011 marked this pull request as ready for review April 22, 2024 16:57
@dipankardas011 dipankardas011 requested review from a team as code owners April 22, 2024 16:57
@AntonioDiTuri AntonioDiTuri mentioned this pull request Apr 25, 2024
Open
16 tasks
rossf7
rossf7 reviewed Apr 30, 2024
View reviewed changes
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
dipankardas011 and others added 3 commits April 30, 2024 23:08
@dipankardas011
patch: improved the docs based on reviews
5cfe905 
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@rossf7
Proposal updates including subscribing to releases
1a1198d 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@rossf7
Updates to goals section
78bc33a 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
rossf7
rossf7 reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proposal is updated to include subscribing to new Falco releases.

The lightest touch way I can see to do that is via the releases atom feed. @leonardpahlke thank you this was great feedback on the previous version!

@nikimanoledaki PTAL when you have time

docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
@rossf7 rossf7 changed the title [Proposal] trigger and deploy [Proposal] Trigger and Deploy May 8, 2024
SFulpius
SFulpius reviewed May 9, 2024
View reviewed changes
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-trigger-and-deploy.md Outdated Show resolved Hide resolved
rossf7
rossf7 reviewed May 9, 2024
View reviewed changes
Copy link
Contributor

@rossf7 rossf7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SFulpius Thank you, that's great feedback. There are a few sections that need to be clearer. I'll address that in the next iteration.

rossf7 added 2 commits May 9, 2024 17:44
@rossf7
Update docs/proposals/proposal-trigger-and-deploy.md
c567e48 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@rossf7
Address review comments
2995f76 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@rossf7 rossf7 force-pushed the feat-proposal-trigger-and-deploy branch from 776fe20 to 2995f76 Compare May 9, 2024 16:03
@dipankardas011 dipankardas011 force-pushed the feat-proposal-trigger-and-deploy branch 2 times, most recently from 38b88c9 to 4af77bd Compare May 12, 2024 17:04
@dipankardas011
feat: added pipeline diagram
00a327b 
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@dipankardas011 dipankardas011 force-pushed the feat-proposal-trigger-and-deploy branch from 4af77bd to 00a327b Compare May 12, 2024 17:06
@rossf7
Use repo variable for storing latest release
29f2b6d 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
dipankardas011 and others added 2 commits May 14, 2024 08:58
@dipankardas011
refactorred the diagram
37b1c28 
Signed-off-by: Dipankar Das <65275144+dipankardas011@users.noreply.github.com>
@rossf7
Update proposal
6094f7c 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@rossf7 rossf7 changed the title [Proposal] Trigger and Deploy Proposal 1: Trigger and Deploy May 17, 2024
@dipankardas011
Copy link
Contributor Author

@rossf7 should we add the github variable part as well or we should test once we almost got the implementation and then we can optimize the variable thing before finishing the issue?

@rossf7
Copy link
Contributor

rossf7 commented May 17, 2024

should we add the github variable part as well

@dipankardas011 I added a note about using variables in the Subscribing to Releases section. Is that OK or do you think more detail is needed?

@dipankardas011
Copy link
Contributor Author

should we add the github variable part as well

@dipankardas011 I added a note about using variables in the Subscribing to Releases section. Is that OK or do you think more detail is needed?

Yes then it's okay, thanks for adding that

@nikimanoledaki nikimanoledaki mentioned this pull request May 18, 2024
Open
@locomundo locomundo mentioned this pull request May 21, 2024
Merged
leonardpahlke
leonardpahlke reviewed May 21, 2024
View reviewed changes
docs/proposals/files/trigger-deploy-pipeline.svg Outdated Show resolved Hide resolved
docs/proposals/files/trigger-deploy.yml Outdated Show resolved Hide resolved
docs/proposals/files/trigger-deploy.yml Outdated Show resolved Hide resolved
docs/proposals/proposal-001-trigger-and-deploy.md Show resolved Hide resolved
@rossf7
Remove example workflow
ffb0454 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@ADiTuri
Copy link

ADiTuri commented May 22, 2024

LGTM, I added just a minor comment, great job!

@rossf7
Address review comments
eee8dd5 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@rossf7
fix: Typos
3ca6ed2 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
AntonioDiTuri
AntonioDiTuri approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@AntonioDiTuri AntonioDiTuri left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, seems like we only have one pending minor discussion, let's wait maximum a week and we can close this

@rossf7
fix: Make check for releases hourly
7161cac 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
nikimanoledaki
nikimanoledaki reviewed May 24, 2024
View reviewed changes
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work and progress on this proposal, well done and thank you @dipankardas011 @rossf7! 🎉 🌟

docs/proposals/proposal-001-trigger-and-deploy.md Show resolved Hide resolved
docs/proposals/proposal-001-trigger-and-deploy.md Outdated Show resolved Hide resolved
docs/proposals/proposal-001-trigger-and-deploy.md Outdated Show resolved Hide resolved
@rossf7
Address review comments
c08f372 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
@rossf7 rossf7 mentioned this pull request May 29, 2024
Merged
@rossf7
Address review comments
88c9228 
Signed-off-by: Ross Fairbanks <ross@rossfairbanks.com>
dipankardas011
dipankardas011 commented May 30, 2024
View reviewed changes
Copy link
Contributor Author

@dipankardas011 dipankardas011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nikimanoledaki
nikimanoledaki approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@nikimanoledaki nikimanoledaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2! 🚀

@rossf7 rossf7 merged commit 50fa8aa into cncf-tags:main May 30, 2024
1 check passed
@rossf7
Copy link
Contributor

rossf7 commented May 30, 2024

First proposal down 🚀

Thank you @dipankardas011 for all your hard work on it and to all the reviewers! 💚

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADiTuri ADiTuri ADiTuri left review comments

@leonardpahlke leonardpahlke leonardpahlke left review comments

@AntonioDiTuri AntonioDiTuri AntonioDiTuri approved these changes

@SFulpius SFulpius SFulpius left review comments

@locomundo locomundo locomundo left review comments

@rossf7 rossf7 rossf7 left review comments

@nikimanoledaki nikimanoledaki nikimanoledaki approved these changes

@guidemetothemoon guidemetothemoon Awaiting requested review from guidemetothemoon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ACTION] Proposal 1: Trigger and Deploy
8 participants
@dipankardas011 @rossf7 @ADiTuri @locomundo @nikimanoledaki @SFulpius @AntonioDiTuri @leonardpahlke