Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboard Kube State Metrics onto CLOMonitor #1380

Closed
wants to merge 3 commits into from

Conversation

jescalada
Copy link
Contributor

This pull request is for Kubernetes Security Slam, Task 7:

The following issue contains all the related tasks:
kubernetes/kube-state-metrics#2274

Feel free to make any changes as required!

Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
data/cncf.yaml Outdated Show resolved Hide resolved
data/cncf.yaml Outdated Show resolved Hide resolved
data/cncf.yaml Outdated Show resolved Hide resolved
@mrueg
Copy link
Contributor

mrueg commented Dec 15, 2023

Thanks for your contribution! I added a couple of questions, from a project side the rest looks good to me.

Edit:Looks good to me.

Signed-off-by: Juan Escalada <97265671+jescalada@users.noreply.github.com>
@jescalada jescalada requested a review from mrueg December 15, 2023 17:54
Copy link

@rexagod rexagod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to link to the corresponding CLO Monitor page within the KSM README (for eg., a badge that points to https://clomonitor.io/projects/cncf/kube-state-metrics)? Thank you for working on this! :)

description: Add-on agent to generate and expose cluster-level metrics.
category: observability
logo_url: https://raw.githubusercontent.com/cncf/artwork/master/projects/kubernetes/icon/color/kubernetes-icon-color.svg
devstats_url: https://k8s.devstats.cncf.io/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should take folks directly to the KSM dashboard.

Suggested change
devstats_url: https://k8s.devstats.cncf.io/
devstats_url: https://k8s.devstats.cncf.io/d/49/github-stats-by-repository?orgId=1&var-period=h24&var-repos=%22kubernetes%2Fkube-state-metrics%22&var-stat=reviewers

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I'm assuming here that the dashboard links are not prone to change and stable, feel free to ignore this if that's not the case)

@tegioz
Copy link
Contributor

tegioz commented Dec 16, 2023

Thanks @jescalada! Kube State Metrics has been added to CLOMonitor as part of #1385.

@tegioz tegioz closed this Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants