Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a sticky header option for the theme #4

Closed
thetwopct opened this issue Aug 17, 2023 · 7 comments
Closed

Provide a sticky header option for the theme #4

thetwopct opened this issue Aug 17, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@thetwopct
Copy link
Collaborator

Similar to what is used on cncf.io see if its easy to build an option so that sticky header can be turned on and off via config

@doolio
Copy link

doolio commented Sep 24, 2023

Similar to what is used on cncf.io

The header doesn't appear to be sticky on cncf.io. It is though on the Chips Alliance site which uses the Sendit Hugo theme.

@cjyabraham
Copy link
Contributor

Are you on www.cncf.io? It should be sticky there. If not, can you provide your browser info?

@doolio
Copy link

doolio commented Sep 25, 2023

Are you on www.cncf.io?

Yes.

It should be sticky there. If not, can you provide your browser info?

That site reported my browser as v102.0 when in fact it is v102.15.lesr.

Device Debug
    Screen Width: 1366
    Screen Height: 768
    Viewport Width: 1364
    Viewport Height: 602
    Browser: Mozilla Firefox 102.15.lesr
    Operating System: Linux
    Raw Browser Info: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Firefox/102.0

@cjyabraham
Copy link
Contributor

On cncf.io, since your viewport height is less than 615px, the header will not be sticky for you to save you some limited vertical real estate. If you expand your viewport taller than 615px then you'll see that the header is sticky.

@doolio
Copy link

doolio commented Sep 25, 2023

I see, thanks for the explanation. I can see it is indeed sticky when I enable full screen mode. I would have assumed it would scale appropriately depending on the device. Do I change this line to expand my viewport? I note it only specifies a width and not a height.

@cjyabraham
Copy link
Contributor

cjyabraham commented Sep 25, 2023

Your viewport is the viewable area inside your browser. To expand your viewport try expanding your browser or, if necessary, use a larger monitor.

@doolio
Copy link

doolio commented Sep 26, 2023

Ah I see thank you. At the moment the most I can do is enter full screen mode and as already stated I can then see the sticky header. Thanks again.

cjyabraham added a commit that referenced this issue Dec 29, 2023
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
@cjyabraham cjyabraham self-assigned this Dec 29, 2023
cjyabraham added a commit that referenced this issue Jan 22, 2024
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
thetwopct pushed a commit that referenced this issue Jan 22, 2024
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants