Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto-add external link icon to external links within topnav menu #53

Closed
cjyabraham opened this issue Jun 4, 2024 · 2 comments
Closed

Auto-add external link icon to external links within topnav menu #53

cjyabraham opened this issue Jun 4, 2024 · 2 comments
Assignees
@cjyabraham

Comments

@cjyabraham
Copy link
Contributor

Similar to how we do this on https://www.cncf.io/. It gives the user a heads up that the link will take them off the current site.
@cjyabraham
Copy link
Contributor Author

I got it working for Gramine.

cjyabraham added a commit that referenced this issue Jun 5, 2024
@cjyabraham
Adds an external link icon beside links that take the user off-site (#53
f6eb03c 
)

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
@cjyabraham cjyabraham mentioned this issue Jun 5, 2024
Merged
@cjyabraham cjyabraham self-assigned this Oct 7, 2024
thetwopct added a commit that referenced this issue Oct 16, 2024
@thetwopct
#53 Rearrange example as its not the most important element of the menu
bc790d0 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>

Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
thetwopct added a commit that referenced this issue Oct 16, 2024
@cjyabraham @thetwopct
Adds an external link icon beside external links (#54)
8a643ff 
* Adds an external link icon beside links that take the user off-site (#53)

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>

* #53 Rearrange example as its not the most important element of the menu

Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>

Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>

---------

Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
Co-authored-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham
Copy link
Contributor Author

This has been done and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cjyabraham cjyabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cjyabraham