Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Misc tweaks #39

Merged
merged 15 commits into from
Jan 22, 2024
Merged

Misc tweaks #39

merged 15 commits into from
Jan 22, 2024

Conversation

cjyabraham
Copy link
Contributor

@cjyabraham cjyabraham commented Dec 29, 2023 •
edited
Loading

This makes a few changes:

  • Pushed the breadcrumb and byline font size up to match the body text. I felt they were too small on the single post pages.
  • I balanced the spacing around some of the heading levels and adjusted a font size.
  • I addressed Implement noindex facility  #2 by providing a way to noindex a page and applied it to the FAQ single-post pages.
  • Adds an intro shortcode for larger text styling of a paragraph as per Add style for an intro paragraph #36
  • Makes cursor "default" for menu items with children on desktop widths so it's clear you can't click them
  • Moved the submenus a bit higher up, closer to the topnav
  • Fixes Should iframe.scss be named _iframe.scss #33

@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for dot-org-hugo-theme-demo-jh ready!

Name Link
🔨 Latest commit 27fe3f3
🔍 Latest deploy log https://app.netlify.com/sites/dot-org-hugo-theme-demo-jh/deploys/65ae206103caba0008d22491
😎 Deploy Preview https://deploy-preview-39--dot-org-hugo-theme-demo-jh.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Dec 29, 2023 •
edited
Loading

✅ Deploy Preview for dot-org-hugo-theme-demo ready!

Name Link
🔨 Latest commit 27fe3f3
🔍 Latest deploy log https://app.netlify.com/sites/dot-org-hugo-theme-demo/deploys/65ae2061c38a64000873df31
😎 Deploy Preview https://deploy-preview-39--dot-org-hugo-theme-demo.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cjyabraham cjyabraham requested a review from thetwopct December 29, 2023 20:46
thetwopct
thetwopct approved these changes Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@thetwopct thetwopct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@thetwopct
Copy link
Collaborator

Reverting my change as it makes sense to use the pointer on mobile 👍

cjyabraham and others added 15 commits January 22, 2024 14:59
@cjyabraham @thetwopct
pushed the breadcrumb and byline font size up to match the body text
2e5613b 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
Tweaked heading sizing and spacing
37d0cf3 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
Provide a way to noindex a page (#2)
126810a 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
don't follow or index when not on production
c053fc8 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
check if env is production
8c36a25 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
try setting the baseurl
ba93265 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
revert a few commits
1751f9a 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
Adds an intro shortcode for larger paragraph text
9e5345e 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
Added bottom margin to intro para
52db710 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
makes cursor default for menu items with children
ddda7e7 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
moved menu submenus up a bit higher
3411d38 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
only change cursor hover on desktop widths
0594a29 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham @thetwopct
Uses correct filename convention for scss files (fixes #33)
ee2a907 
Signed-off-by: Chris Abraham <cjyabraham@gmail.com>
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Updating cursor to be applied if device supports hover
39dba37 
Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@thetwopct
Revert "Updating cursor to be applied if device supports hover"
27fe3f3 
This reverts commit c3935a7.

Signed-off-by: James Hunt <10615884+thetwopct@users.noreply.github.com>
@cjyabraham cjyabraham merged commit fc10451 into main Jan 22, 2024
9 checks passed
@cjyabraham cjyabraham deleted the misc branch January 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thetwopct thetwopct Awaiting requested review from thetwopct

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should iframe.scss be named _iframe.scss
2 participants
@cjyabraham @thetwopct