Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete Slack link #1000

Merged
merged 2 commits into from
Jun 27, 2022
Merged

complete Slack link #1000

merged 2 commits into from
Jun 27, 2022

Conversation

Petrie
Copy link
Contributor

@Petrie Petrie commented Jun 27, 2022

Complete CNCF Slack link.

Signed-off-by: Petrie <lpfvip2008@gmail.com>
@netlify
Copy link

netlify bot commented Jun 27, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit a4d1095
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/62b98158605ce400089677c6
😎 Deploy Preview https://deploy-preview-1000--cncfglossary.netlify.app/zh-cn/contribute
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@seokho-son
Copy link
Collaborator

@Petrie Thank you for the contribution !!

looks good to me except one thing.

Please remove changes in localized contents.
In main branch, we need to avoid changing localized contents to prevent conflicts.
You can find development branch for each language.
for instance, dev-zh branch for Chinese.

@seokho-son seokho-son added the lang/en for English label Jun 27, 2022
Signed-off-by: Petrie <lpfvip2008@gmail.com>
@Petrie
Copy link
Contributor Author

Petrie commented Jun 27, 2022

@Petrie Thank you for the contribution !!

looks good to me except one thing.

Please remove changes in localized contents. In main branch, we need to avoid changing localized contents to prevent conflicts. You can find development branch for each language. for instance, dev-zh branch for Chinese.

Thanks for the detailed explanation, I have remove changes in localized contents.

Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iamNoah1 iamNoah1 merged commit ea40142 into cncf:main Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/en for English
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants