Get Search working on PR instance #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
cjyabraham
requested review from
caniszczyk,
CathPag,
JasonMorgan,
seokho-son,
iamNoah1 and
jihoon-seo
as code owners
jihoon-seo
added
the
maintainers
|
Hmm...I just tested it and it still throws me back to the live site...or did I misunderstand what this PR is about? |
|
You tested this instance? https://deploy-preview-1050--cncfglossary.netlify.app/ |
|
Yep, just send you a screenrecording via Slack |
|
@cjyabraham would there be no side effect from replacing |
|
I don't think so as that is the way we do it over on the Contribute site: https://github.com/cncf/tag-contributor-strategy/blob/main/website/config.toml#L1 We should definitely test it thoroughly when we deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the search form on PR instance redirects to the live Glossary site. This PR is to get it so that the form keeps the user on current instance.
If you go to this dev instance and search for something, you'll see the search results now appear on the same dev instance rather than going to the live site.
Signed-off-by: cjyabraham cjyabraham@gmail.com