[PTBR] Add MrErlison as a Portuguese approver #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jihoon-seo
added
lang/pt
edsoncelio
requested review from
caniszczyk,
CathPag,
JasonMorgan,
seokho-son,
iamNoah1 and
jihoon-seo
as code owners
|
Please @jihoon-seo @jihoon-seo could you take a look at it? 🙏🏽 |
|
@MrErlison could just confirm that you're aware of this please? |
|
Hi @MrErlison PTAL Policies for localization approvers (to be confirmed by candidates) and please leave a comment here to confirm you read the policy and understand it. |
Hi @seokho-son I read the policies and understood. |
iamNoah1
approved these changes
Aug 8, 2022
yunkon-kim
pushed a commit
to yunkon-kim/glossary
that referenced
this pull request
Sep 5, 2022
* feat: add MrErlison as a ptbr approver
jasonsmithio
pushed a commit
to jasonsmithio/glossary
that referenced
this pull request
Sep 7, 2022
* feat: add MrErlison as a ptbr approver Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
jasonsmithio
pushed a commit
to jasonsmithio/glossary
that referenced
this pull request
Sep 7, 2022
* feat: add MrErlison as a ptbr approver Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add @MrErlison as approver to the Portuguese team.
He’s a great contributor and is helping us a lot.
Here you can a list of the contributions.