Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a pull request template #1234

Merged
merged 3 commits into from
Aug 18, 2022
Merged

Create a pull request template #1234

merged 3 commits into from
Aug 18, 2022

Conversation

seokho-son
Copy link
Collaborator

Signed-off-by: Seokho Son shsongist@gmail.com

Describe your changes

This PR is to add a PR template.

Related issue number or link

No open issue. It is an action item from a maintainers' meeting.

Checklist before opening this PR (put x in the check-boxes)

  • This PR does not contain plagiarism
    • don’t copy and paste other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO

Signed-off-by: Seokho Son <shsongist@gmail.com>
@netlify
Copy link

netlify bot commented Aug 17, 2022

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 9e0c1e6
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/62fd9558af759f0009c7c7f5
😎 Deploy Preview https://deploy-preview-1234--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Signed-off-by: Seokho Son <shsongist@gmail.com>
@seokho-son seokho-son added the maintainers Use this label if PR requires maintainers to take action label Aug 17, 2022
Copy link
Collaborator

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @seokho-son
LGTM

Signed-off-by: Seokho Son <shsongist@gmail.com>
Copy link
Collaborator

@jihoon-seo jihoon-seo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jihoon-seo jihoon-seo merged commit 2c3ffe1 into main Aug 18, 2022
@jihoon-seo jihoon-seo deleted the pr-template branch August 18, 2022 01:31
jasonsmithio pushed a commit to jasonsmithio/glossary that referenced this pull request Sep 7, 2022
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
jasonsmithio pushed a commit to jasonsmithio/glossary that referenced this pull request Sep 7, 2022
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
jasonsmithio pushed a commit to jasonsmithio/glossary that referenced this pull request Sep 7, 2022
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
jasonsmithio pushed a commit to jasonsmithio/glossary that referenced this pull request Sep 9, 2022
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
iamNoah1 added a commit that referenced this pull request Sep 22, 2022
* First attempt at Event Streaming

Issue #346

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Create a pull request template (#1234)

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Keeping it generic, I love it

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Updated technical definition

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* fixed minor spelling error

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Adding definitions

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* updated wordlist and event-streaming.md

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* signing and wordlist update

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Small edits

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>

* changed NASDAQ to Yahoo Finance

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>

* two tweaks

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>

* Update content/en/event-streaming.md

Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
seokho-son added a commit to seokho-son/glossary that referenced this pull request Mar 20, 2023
* First attempt at Event Streaming

Issue cncf#346

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Create a pull request template (cncf#1234)

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Keeping it generic, I love it

Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Updated technical definition

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* fixed minor spelling error

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Adding definitions

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* updated wordlist and event-streaming.md

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* signing and wordlist update

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Small edits

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>

* changed NASDAQ to Yahoo Finance

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>

* Update content/en/event-streaming.md

Co-authored-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>

* two tweaks

Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>

* Update content/en/event-streaming.md

Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>

Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io>
Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Co-authored-by: Seokho Son <shsongist@gmail.com>
Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainers Use this label if PR requires maintainers to take action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants