-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a pull request template #1234
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Seokho Son <shsongist@gmail.com>
seokho-son
requested review from
caniszczyk,
CathPag,
JasonMorgan,
iamNoah1 and
jihoon-seo
as code owners
August 17, 2022 14:05
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: Seokho Son <shsongist@gmail.com>
seokho-son
added
the
maintainers
Use this label if PR requires maintainers to take action
label
Aug 17, 2022
iamNoah1
approved these changes
Aug 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @seokho-son
LGTM
jihoon-seo
reviewed
Aug 17, 2022
seokho-son
commented
Aug 18, 2022
Signed-off-by: Seokho Son <shsongist@gmail.com>
jihoon-seo
approved these changes
Aug 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jasonsmithio
pushed a commit
to jasonsmithio/glossary
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
jasonsmithio
pushed a commit
to jasonsmithio/glossary
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
jasonsmithio
pushed a commit
to jasonsmithio/glossary
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
jasonsmithio
pushed a commit
to jasonsmithio/glossary
that referenced
this pull request
Sep 9, 2022
Signed-off-by: Jason (Jay) Smith <jaysmith@google.com>
iamNoah1
added a commit
that referenced
this pull request
Sep 22, 2022
* First attempt at Event Streaming Issue #346 Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Create a pull request template (#1234) Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Keeping it generic, I love it Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Updated technical definition Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * fixed minor spelling error Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Adding definitions Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * updated wordlist and event-streaming.md Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * signing and wordlist update Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Small edits Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> * changed NASDAQ to Yahoo Finance Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> * two tweaks Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> * Update content/en/event-streaming.md Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
seokho-son
added a commit
to seokho-son/glossary
that referenced
this pull request
Mar 20, 2023
* First attempt at Event Streaming Issue cncf#346 Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Create a pull request template (cncf#1234) Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Keeping it generic, I love it Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Updated technical definition Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * fixed minor spelling error Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Adding definitions Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * updated wordlist and event-streaming.md Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * signing and wordlist update Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Small edits Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> * changed NASDAQ to Yahoo Finance Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> * Update content/en/event-streaming.md Co-authored-by: Seokho Son <shsongist@gmail.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> * two tweaks Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> * Update content/en/event-streaming.md Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Signed-off-by: Jason (Jay) Smith <jaysmith@google.com> Signed-off-by: Jason (Jay) Smith <jay@jasonsmith.io> Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com> Co-authored-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com> Co-authored-by: Seokho Son <shsongist@gmail.com> Co-authored-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Seokho Son shsongist@gmail.com
Describe your changes
This PR is to add a PR template.
Related issue number or link
No open issue. It is an action item from a maintainers' meeting.
Checklist before opening this PR (put
x
in the check-boxes)git commit -s
) is to affirm that commits comply DCO