Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hi] Localize content/hi/cloud-computing.md #1250

Merged
merged 9 commits into from
Jun 25, 2023
Merged

[hi] Localize content/hi/cloud-computing.md #1250

merged 9 commits into from
Jun 25, 2023

Conversation

shivam-sharma7
Copy link
Contributor

@shivam-sharma7 shivam-sharma7 commented Aug 21, 2022 •
edited
Loading

  • created a cloud-computing.md file and Localise in Hindi who prefer learning and understanding more in the Hindi language can understand better.

issue: #1005

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO.

@shivam-sharma7
Create cloud-computing.md
a9e62bd 
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
@netlify
Copy link

netlify bot commented Aug 21, 2022 •
edited
Loading

✅ Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 5ecfaae
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/644405db5a264e00082cb99d
😎 Deploy Preview https://deploy-preview-1250--cncfglossary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sarkartanmay393
Copy link
Contributor

sarkartanmay393 commented Aug 21, 2022 •
edited
Loading

@shivam-sharma7 You can change the PR's name from Create cloud-computing.md to [hi] Localize cloud-computing.md or [hi] Localize content/hi/cloud-computing.md

@shivam-sharma7 shivam-sharma7 changed the title Create cloud-computing.md [hi] Localize content/hi/cloud-computing.md Aug 21, 2022
@jihoon-seo jihoon-seo added the lang/hi for Hindi label Aug 22, 2022
@jihoon-seo jihoon-seo linked an issue Aug 22, 2022 that may be closed by this pull request
Localise 'Cloud Computing' to Hi #1242
Closed
2 tasks
@bishal7679
Copy link
Collaborator

@jihoon-seo An issue to localize cloud-computing in hindi has been already raised #1005 and is assigned to @devsachinsharma. If @devsachinsharma is not working on that issue then we could consider this PR

__
sema-logo  Summary: 🛠️ This code needs a fix

@jihoon-seo jihoon-seo linked an issue Aug 27, 2022 that may be closed by this pull request
[hi] Localize Cloud computing #1005
Closed
@Garima-Negi
Copy link
Collaborator

@shivam-sharma7 can you join us on slack : cloud-native.slack.com on the #glossary-localization-hindi channel?

Garima-Negi
Garima-Negi requested changes Sep 23, 2022
View reviewed changes
Copy link
Collaborator

@Garima-Negi Garima-Negi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shivam-sharma7 the PR looks good, can you also fix the alignment of the sentences? they seem to be on extra newlines and discontinued. thanx!

@shivam-sharma7
alignment of the sentences fix
ae8f95d 
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
sayantani11
sayantani11 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@sayantani11 sayantani11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

anubha-v-ardhan
anubha-v-ardhan suggested changes Apr 22, 2023
View reviewed changes
Copy link
Contributor

@anubha-v-ardhan anubha-v-ardhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thankyou @shivam-sharma7 for your contributions.
Sorry for the extremely long time this review took

content/hi/cloud-computing.md Outdated Show resolved Hide resolved
content/hi/cloud-computing.md Outdated Show resolved Hide resolved
content/hi/cloud-computing.md Outdated Show resolved Hide resolved
shivam-sharma7 and others added 3 commits April 22, 2023 21:35
@shivam-sharma7 @anubha-v-ardhan
Update content/hi/cloud-computing.md
4fe2258 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
@shivam-sharma7 @anubha-v-ardhan
Update content/hi/cloud-computing.md
8ac3650 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
@shivam-sharma7 @anubha-v-ardhan
Update content/hi/cloud-computing.md
5ecfaae 
Co-authored-by: Anubhav Vardhan <vardhananubhav@gmail.com>
Signed-off-by: Shivam Sharma <meshivam81@gmail.com>
@shivam-sharma7
Copy link
Contributor Author

LGTM! Thankyou @shivam-sharma7 for your contributions. Sorry for the extremely long time this review took

No problem! 🙂

@anubha-v-ardhan anubha-v-ardhan changed the base branch from main to dev-hi June 24, 2023 15:57
@anubha-v-ardhan anubha-v-ardhan changed the base branch from dev-hi to main June 24, 2023 15:58
@anubha-v-ardhan anubha-v-ardhan changed the base branch from main to dev-hi June 25, 2023 13:53
@anubha-v-ardhan anubha-v-ardhan merged commit 8bc5437 into cncf:dev-hi Jun 25, 2023
@anubha-v-ardhan
Copy link
Contributor

Thank You @shivam-sharma7

@shivam-sharma7 shivam-sharma7 deleted the shivam-sharma7-patch-1 branch June 25, 2023 15:21
This was referenced Jun 28, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayantani11 sayantani11 sayantani11 approved these changes

@anubha-v-ardhan anubha-v-ardhan anubha-v-ardhan approved these changes

@jayesh-srivastava jayesh-srivastava jayesh-srivastava approved these changes

@Garima-Negi Garima-Negi Garima-Negi approved these changes

Assignees
No one assigned
Labels
lang/hi for Hindi
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Localise 'Cloud Computing' to Hi [hi] Localize Cloud computing
8 participants
@shivam-sharma7 @sarkartanmay393 @bishal7679 @Garima-Negi @anubha-v-ardhan @jayesh-srivastava @sayantani11 @jihoon-seo