Add service models and modify documentation #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adding primary service models to the documentation and modifying it for a better understanding and readability. Signed-off-by: Kiran Satya Raj <90622705+KiranSatyaRaj@users.noreply.github.com>
KiranSatyaRaj
requested review from
caniszczyk,
CathPag,
JasonMorgan,
seokho-son,
iamNoah1 and
jihoon-seo
as code owners
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jihoon-seo
added
lang/en
iamNoah1
requested changes
Sep 5, 2022
There was a problem hiding this comment.
Thanks @KiranSatyaRaj for your contribution. I have some change requests :)
KiranSatyaRaj
commented
Sep 6, 2022
iamNoah1
requested changes
Sep 6, 2022
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
Signed-off-by: Noah Ispas <13436814+iamNoah1@users.noreply.github.com>
iamNoah1
approved these changes
Sep 6, 2022
|
thanks @KiranSatyaRaj :) |
Signed-off-by: Catherine Paganini <74001907+CathPag@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding primary service models to the documentation and modifying it for a better understanding and readability.
Signed-off-by: Kiran Satya Raj 90622705+KiranSatyaRaj@users.noreply.github.com
Describe your changes
Related issue number or link (ex:
resolves #issue-number)Checklist before opening this PR (put
xin the checkboxes)git commit -s) is to affirm that commits comply DCO.