-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable labeler workflow #1286
Enable labeler workflow #1286
Conversation
Signed-off-by: Seokho Son <shsongist@gmail.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
PTAL @yunkon-kim |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@seokho-son I have a simple suggestion as follows :-)
.github/workflows/labeler.yml
Outdated
- 'content/**' | ||
branches: | ||
- '**' | ||
- pull_request_target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amending to @yunkon-kim's suggestion:
- pull_request_target | |
pull_request_target: | |
types: [opened, synchronize] | |
paths: | |
- 'content/**.md' | |
branches: | |
- 'dev-**' | |
- 'main' |
If we add 'main' as target branch, then this will automatically label lang/en
for the PRs that add/modify 'content/en/**.md' and target main
!
For information:
The default value of sync-labels
is false
. (https://github.com/actions/labeler#inputs)
We might need to add action.yml
to this repo and set the value of sync-labels
to true
,
to make synchronize
-related thing work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jihoon-seo thanks for your updates!
I agree that main
is a vital point in this workflow.
For a simple discussion:
I was thinking about the synchronize
type. However, I couldn't find any cases of reassigning the label when synchronizing.
Also, when we add the synchronize
type, this workflow will be triggered by every PR synchronization.
Therefore, it would be nice to add the 'synchronize' as needed.
If anyone has a case that synchronize
is necessary, please feel free to share.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed "synchronize" for this time. Let's see it is necessary after some period. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
main
was not added to the branches
section. Is it ok?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yunkon-kim Added :)
Co-authored-by: Yunkon Kim <7975459+yunkon-kim@users.noreply.github.com> Signed-off-by: Seokho Son <shsongist@gmail.com>
Signed-off-by: Seokho Son <shsongist@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@iamNoah1 I think this PR is ready :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@seokho-son |
Signed-off-by: Seokho Son shsongist@gmail.com
Describe your changes
pull_request_target
option)Related issue number or link (ex:
resolves #issue-number
)Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO.