Stop incomplete terms from showing up in search results and tag listing pages #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Signed-off-by: cjyabraham <cjyabraham@gmail.com>
cjyabraham
requested review from
caniszczyk,
CathPag,
JasonMorgan,
seokho-son,
iamNoah1 and
jihoon-seo
as code owners
jihoon-seo
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
- "don't list incomplete terms in tag listing"
- As-is: https://glossary.cncf.io/tags/fundamentals/#:~:text=Fundamentals-,Stateless%20Apps,-Fundamentals
(The status of the term "Stateless Apps" is "feedback appreciated", but the term is listed in the "fundamentals" tag page.) - To-be: https://deploy-preview-1292--cncfglossary.netlify.app/tags/fundamentals/
(The term "Stateless Apps" is not listed in the "fundamentals" tag page.)
- As-is: https://glossary.cncf.io/tags/fundamentals/#:~:text=Fundamentals-,Stateless%20Apps,-Fundamentals
- "only allow robots to index on Completed pages"
- As-is:
- To-be:
- As-is:
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1291
Signed-off-by: cjyabraham cjyabraham@gmail.com